-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
강원대 FE_허윤수 3주차 과제 Step1 #34
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- themeKey가 유효하지 않으면 메인 페이지(RouterPath.home)로 리다이렉트
- themeApi의 fetchThemeProduct 함수에 maxResults 파라미터 추가 - ProductSection 컴포넌트를 수정하여 20개의 상품 목록을 요청하도록 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요, 강원대학교 허윤수입니다.
STEP을 모두 구현한 PR을 확인해주시면 감사하겠습니다.
해결하였습니다.
1. 2주차 과제(https://github.com/kakao-tech-campus-2nd-step2/react-gift-ui-flow/pull/60)에서 themeKey를 사용한 label, title, description 변환 및 backgroundColor 변경 로직이 작동하지 않아 질문드립니다. 이전에 "themeKey를 넣어주지 않았다"는 답변을 받았지만, 아직 props 사용하는 것이 익숙하지 않아 해당 기능이 작동하지 않습니다. 3주차 과제에서도 동일한 문제가 발생합니다.해결하였습니다.
2. Vercel 배포 환경과 oys.yaml 파일의 기능이 무엇인가요? Vercel에서 데이터를 전달하고, oys.yaml 파일에 정의된 api 주소를 사용해 데이터를 활용하는 방식인가요? 또한, oys.yaml 파일을 사용해 Vercel과 연동되는 것인지 궁금합니다.