전남대 Android_이가현 5주차 step2 과제 #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigstark
requested changes
Jul 27, 2024
Comment on lines
+16
to
+21
| return ViewHolder( | ||
| ItemViewBinding.inflate( | ||
| LayoutInflater.from(parent.context), | ||
| parent, | ||
| false | ||
| ) |
| override fun onBindViewHolder(holder: ViewHolder, position: Int) { | ||
| val location = getItem(position) | ||
| holder.bind(location) | ||
| holder.itemView.setOnClickListener { onItemClick(location) } |
There was a problem hiding this comment.
onBindViewHolder 시점에 setOnClickListener 는 성능이 좋지 않습니다. 안티패턴이에요.
holder 내부의 init 시점으로 옮겨주시는 편이 좋습니다.
ViewHolder 생성 시 onItemClick lambda 도 같이 추가하면 좋을 것 같네요 :)
| private fun saveSearchList() { | ||
| val sharedPref = getPreferences(Context.MODE_PRIVATE) | ||
| val sharedPref = getPreferences(MODE_PRIVATE) |
There was a problem hiding this comment.
shared preference 로 처리하는 로직도 viewModel 로 옮겨주시면 어떨까요?
추가적으로 shared preference 또한 주입받는 대상으로 처리해주시는 것이 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
감사합니다