부산대 Android_김현민 5주차 과제 Step2 #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database
Step1 README
* Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md * Initial commit * Fix: Fix Week2 error * Docs: Update README.md Step1 README * Feat: Add initial settings * Feat: Add Document data class * Feat: Add RetrofitService interface * Refactor: Delete DB code * Feat: Add search function using API * Feat: Separate CategoryGroupCode * Docs: Update step2 README.md * Feat: complete initial project setup * Feat: Add mapview and map function * Fix: resolve errors * Chore: Update network security configuration * Fix: Resolve windows emulator issue * Style: Update mapview design * 부산대 Android_김현민 3주차 과제 Step0 (kakao-tech-campus-2nd-step2#19) * Initial commit * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Docs: Update README.md * Feat: Create item_view * Feat: Modify main view * Feat: Implement search list * Feat: Complete saved element view * Feat: Complete save action * Feat: Add persistent save function * 부산대 Android_김현민_2주차_과제_Step1 (kakao-tech-campus-2nd-step2#2) * Docs: Update README.md * Feat: Complete search screen layout * Feat: Add data to the database * Design: Modify save element design * Update README.md --------- Co-authored-by: MyStoryG <[email protected]> * Fix: Reflect feedback * Fix: Resolve error * Docs: Update README.md * Feat: Add location marker * Feat: Add camera movement function * Feat: Add bottom sheet dialog * Feat: Add initial camera location function * Refactor: Resolve initial camera issue and search issue * Feat: Add map error event * Design: Modify UI design * Refactor: Separate function and write annotations * Docs: Update README.md * Feat: Add save item click function * Feat: Add keyword search function * Update README.md --------- Co-authored-by: MyStoryG <[email protected]>
dependency injection about network
dependency injection about map utility
dependency injection about map search service
dependency injection about search save service
dependency injection about bottomsheet
Resolve errors caused by code modification during refactoring process
Utilize LiveData and DataBinding
Utilize LiveData and DataBinding
Utilize LiveData and DataBinding
LeeOhHyung
approved these changes
Jul 28, 2024
Comment on lines
+47
to
+59
|
|
||
| private fun handleSearchResult(result: KakaoResponse?) { | ||
| result?.documents?.let { documents -> | ||
| if (documents.isEmpty()) { | ||
| _noResult.value = true | ||
| } else { | ||
| val profilesList = documents.map { it.toProfile() } | ||
| _profiles.value = profilesList | ||
| } | ||
| } ?: run { | ||
| _noResult.value = true | ||
| } | ||
| } |
There was a problem hiding this comment.
network layer에서 결과를 전달받을때 response 전체를 받기보다는 원하는 데이터인 documents만 전달받는게 좀더 깔끔할것 같습니다! UI layer에서 원하는것은 api응답 이라기 보다는 확인하고자 하는 document 데이터 이기 때문이죠!
그렇게 되면 searchService 를 중간에서 확인해 documents만 전달해주는 중간 전달자를 두는 방법이 있겠죠. 보통은 repository나 usecase 라는 이름을 사용해서 만들고 있습니다
There was a problem hiding this comment.
KakaoResponse 라는 클래스가 data 에도 있고, network 패키지에도 있네요. 둘중 하나는 제거해도 될것 같습니다
Comment on lines
+53
to
+56
| lifecycleScope.launch { | ||
| withContext(Dispatchers.IO) { | ||
| db.profileDao().insertAll(*profiles.toTypedArray()) | ||
| } |
There was a problem hiding this comment.
아하.. database에 데이터는 insert 하는것은 ui에서 수행하기 보다는 data layer에 있는 것이 적절합니다.
따라서, observe 할때 수행되기 보다는 ViewModel 에서 profiles livedata에 값을 전달해주는 시점에 바로 db insert 시키는 방법이 더 좋을것 같습니다. Activity에는 데이터를 다루는 로직보다는 정말 UI와 관련된 부분만 존재하게 되는것이죠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step2 커밋 링크
(Step2 커밋만 select 하였습니다!)
https://github.com/kakao-tech-campus-2nd-step2/android-map-refactoring/pull/69/files/59c928d0e692a0145af1e559d807abd57e882fa3..261f6a36a1f9245616378c14a20926140a0b00aa
느낀 점
질문드리고 싶은 점