-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
경북대 Android_유지예_5주차과제_Step2 #67
Open
YJY1220
wants to merge
23
commits into
kakao-tech-campus-2nd-step2:yjy1220
Choose a base branch
from
YJY1220:feat-JiyeYU-2
base: yjy1220
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
경북대 Android_유지예_5주차과제_Step2 #67
YJY1220
wants to merge
23
commits into
kakao-tech-campus-2nd-step2:yjy1220
from
YJY1220:feat-JiyeYU-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
데이터바인딩은 적용되지 않은것으로 보이네요! |
추가로 Step 1을 선 리뷰하고 머지했는데, 컨플릭이 나는데요. 이거 수정해주시면 머지 가능합니다! |
databinding 적용과 step1 수정사항을 반영하여 새로운 pr을 올렸습니다! 다만, 충돌이 너무 많이 나서 웹에서 수정이 안된다고 하여 방법을 찾아보는 중입니다...! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어려웠던 점 & 느낀 점
[MVVM 패턴 적용 - LiveData, Databinding]
[비동기 처리 - Coroutine으로 변경]
멘토님께서 중점적으로 봐주셨으면 좋겠는 점