-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
전남대 Android_이민서_5주차 과제_Step 1 #51
base: leeminseo00
Are you sure you want to change the base?
전남대 Android_이민서_5주차 과제_Step 1 #51
Conversation
|
||
private val placeDao: PlaceDao = AppDatabase.getDatabase(application).placeDao() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
�사용하지 않는 코드는 제거해주세요 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step2를 진행하며 사용하지 않는 코드를 삭제했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step1에도 적용하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래에서 말씀해주신 패키지 구조 변경은 Step 2 피드백에서 반영해도 될까요?
전체적으로 1단계 코드 잘 작성해주셨습니다. 고생하셨어요.
보통은 말씀해주신대로 컴포넌트 별로 만들거나, 기능 별로 분류 합니다. 지금 같이 간단한 프로젝트에서는 어떻게 나누어도 좋으니 하나를 선택하여 패키지 구조를 변경해보세요. ㅎㅎ |
5주차 과제_Step 1
리팩터링: 1단계 의존성 주입
코드 작성하며 어려웠던 점
멘토님이 중점적으로 리뷰 해주셨으면 하는 부분