부산대 Android_김정희_6주차 과제_2단계 #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # app/build.gradle.kts # app/src/main/AndroidManifest.xml # app/src/main/res/layout/activity_main.xml # app/src/main/res/values/strings.xml # build.gradle.kts # gradle/wrapper/gradle-wrapper.properties # settings.gradle.kts
LeeOhHyung
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
@lovelhee LGTM~ 👍 step1 코드에 달아주신 코멘트들도 확인했습니다.
step2는 FCM을 구현하는것이라 코드 추가는 많지 않고, 이제 많이 익숙해져서 그런지 코멘트 드릴것도 거의 없네요. 아마 파이어베이스 콘솔에서 FCM을 보내는게 더 어려웠지 않았을까 싶네요.
6주차 과제도 고생많으셨습니다!
Comment on lines
+205
to
+214
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { | ||
| if (ContextCompat.checkSelfPermission( | ||
| this, | ||
| android.Manifest.permission.POST_NOTIFICATIONS | ||
| ) == | ||
| PackageManager.PERMISSION_GRANTED | ||
| ) { | ||
| Log.d("MapActivity", "알림 권한 이미 허용") | ||
| // FCM SDK (and your app) can post notifications. | ||
| } else if (shouldShowRequestPermissionRationale(android.Manifest.permission.POST_NOTIFICATIONS)) { |
There was a problem hiding this comment.
!= 으로 권한 허용이 안되어 있는 경우로 확인한다면, if-else 문을 하나 줄일 수 있을것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님!
벌써 멘토님께 받을 마지막 리뷰라고 생각하니 뭔가 ... 시원 섭섭하네요.
6주라는 긴 시간동안 현업하시는 와중에도 꼼꼼하게 리뷰 남겨주셔서 너무너무 감사했습니다!!
언젠가 다시 만날 수 있기를 바랍니다 .. !! 항상 좋은 일만 생기세요 ~!!
2단계 커밋 모음
https://github.com/kakao-tech-campus-2nd-step2/android-map-notification/pull/83/files/77fd1dc52ced1d40a4657f1be6e01f8409b21ed0..b630e30a20b75a3cecd81a3eb615d2a3927be4c3
실행 결과
[포그라운드]
-.Clipchamp.3.mp4
[백그라운드]