-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
전남대 Android_이민서_6주차 과제_Step2 #76
Open
LEEMINSEO00
wants to merge
7
commits into
kakao-tech-campus-2nd-step2:leeminseo00
Choose a base branch
from
LEEMINSEO00:step2
base: leeminseo00
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
전남대 Android_이민서_6주차 과제_Step2 #76
LEEMINSEO00
wants to merge
7
commits into
kakao-tech-campus-2nd-step2:leeminseo00
from
LEEMINSEO00:step2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omjoonkim
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2단계 과제도 잘 진행해주셨습니다~! 수고하셨어요 ㅎㅎ
@@ -43,4 +63,50 @@ class SplashActivity : AppCompatActivity() { | |||
} | |||
}) | |||
} | |||
} | |||
|
|||
private fun askNotificationPermission() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금은 한곳에서만 권한요구를 하지만, 서비스가 커질수록 로직이 재활용될 가능성이 높아집니다. 여러 화면에서 코드를 재활용 할 수 있도록 리팩토링을 진행햅보셔요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6주차 과제_Step 2
알림: 2단계 푸시 알림
코드 작성하며 어려웠던 점
멘토님이 중점적으로 리뷰 해주셨으면 하는 부분
실행 결과