전남대 Android_최영빈_6주차 과제_step1 #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기본 코드 준비
- 구현할 기능 목록 정리
…ig's serviceState - serviceState 값이 ON_SERVICE일 때만 초기 진입 화면이 지도 화면으로 넘어감
…State is not ON_SERVICE - serviceState 값이 ON_SERVICE이 아닌 경우에는 serviceMessage 값을 초기 진입 화면 하단에 표시하고 지도 화면으로 진입하지 않음
omjoonkim
approved these changes
Aug 2, 2024
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class RemoteConfig @Inject constructor() { |
There was a problem hiding this comment.
테스트의 용이성을 위해 클래스를 추상화하는 것이 어떨까요?
SplashRepository를 테스트 할 때, Firebase에 대한 의존성 없이 테스트가 가능해질거에요 ㅎㅎ
|
영빈님 1단계 과제 진행하시느라 수고하셨습니다. 따로 코멘트 드릴 것은 없습니다. ㅎㅎ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드 작성하면서 어려웠던 점
멘토님이 중점적으로 리뷰해 주셨으면 하는 부분
+) splash 라이브러리가 추가 되어 있지 않아 적용하지 않았는데,
스플래시 화면를 적용했어야 하는 과제였는지 궁금합니다.