전남대 Android_이민서_6주차 과제_Step 1 #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omjoonkim
approved these changes
Aug 2, 2024
| val fetchSuccess: LiveData<Boolean> get() = _fetchSuccess | ||
|
|
||
| fun fetchRemoteConfig(remoteConfig: FirebaseRemoteConfig) { | ||
| remoteConfig.fetchAndActivate() |
There was a problem hiding this comment.
ViewModel에서 안드로이드에 의존적인 코드를 최대한 덜어내보세요.
이 로직의 역할을 담당하는 컴포넌트를 만들고 추상화하여 사용해보셔요.
|
크게 코멘트 할 것은 없었습니다. ㅎㅎ 수고하셨어요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6주차 과제_Step 1
알림: 1단계 Splash Screen
코드 작성하며 어려웠던 점
멘토님이 중점적으로 리뷰 해주셨으면 하는 부분