Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves kafbat/kafka-ui#90 Added contract profile, to only build API, local profile now builds frontend #669

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Resolves kafbat/kafka-ui#90 Added contract profile, to only build API, local profile now builds frontend #669

wants to merge 5 commits into from

Conversation

KliminV
Copy link

@KliminV KliminV commented Nov 22, 2024 •
edited
Loading

Added contract profil, to only build API
Local profile now builds frontend

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@KliminV
Added contract profile, to only build API.
d7ad473 
Local profile now builds frontend
@KliminV KliminV requested a review from a team as a code owner November 22, 2024 20:10
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress scope/frontend Related to frontend changes status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 22, 2024
github-actions[bot]
github-actions bot reviewed Nov 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi KliminV! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@KliminV
Copy link
Author

KliminV commented Nov 22, 2024 •
edited
Loading

I think no unit tests are needed. However I would be happy to update documentation if needed
Also, can't link issue myself #90

@KliminV KliminV closed this Nov 23, 2024
@KliminV
resolves kafbat#90
6927e2b 
Moved parent modules section into profiles
Added default profile to build all modules.
UI now only runs with local / prod profiles, but skipped by default
@KliminV KliminV reopened this Nov 23, 2024
@KliminV
Copy link
Author

KliminV commented Nov 26, 2024

@Haarolean could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KliminV