Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Fix ECR push action #588

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Infra: Fix ECR push action #588

merged 1 commit into from
Oct 8, 2024

Conversation

azatsafin
Copy link
Member

@azatsafin azatsafin commented Oct 8, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

Fix env reference in the image build/push workflow. The ECR_REGISTRY Configuration variable configured on repo level.
Is there anything you'd like reviewers to focus on?
Fixes #583

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@azatsafin azatsafin requested a review from a team as a code owner October 8, 2024 12:34
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 8, 2024
@Haarolean Haarolean added type/bug Something isn't working scope/infra CI, CD, dev. env, etc. and removed status/triage/manual Manual triage in progress labels Oct 8, 2024
@Haarolean Haarolean changed the title Fix env reference in the image build/push workflow Infra: Fix ECR push action Oct 8, 2024
@Haarolean Haarolean merged commit 91ed167 into main Oct 8, 2024
33 of 34 checks passed
@Haarolean Haarolean deleted the fix-env-reference branch October 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra: ECR push fails
2 participants