Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: ECR Build minor fixes #580

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Infra: ECR Build minor fixes #580

merged 3 commits into from
Oct 9, 2024

Conversation

azatsafin
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

Add ECR login via OIDC provider

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@azatsafin azatsafin requested a review from a team as a code owner October 7, 2024 17:49
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 7, 2024
@azatsafin azatsafin added status/triage Issues pending maintainers triage status/feature_testing_public This branch/PR has been deployed to a separate PUBLIC environment for testing. and removed status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed status/triage Issues pending maintainers triage labels Oct 7, 2024
@azatsafin azatsafin added status/image_testing and removed status/feature_testing_public This branch/PR has been deployed to a separate PUBLIC environment for testing. status/image_testing labels Oct 7, 2024
Copy link

github-actions bot commented Oct 9, 2024

Image published at public.ecr.aws/s0v8j8q9/kafbat/kafka-ui:580

@azatsafin azatsafin self-assigned this Oct 9, 2024
@Haarolean Haarolean changed the title Ecr login Infra: ECR Build minor fixes Oct 9, 2024
@Haarolean Haarolean merged commit fbef485 into main Oct 9, 2024
5 of 6 checks passed
@Haarolean Haarolean deleted the ecr-login branch October 9, 2024 08:49
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature type/bug Something isn't working scope/infra CI, CD, dev. env, etc. and removed status/image_testing labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. type/bug Something isn't working type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants