-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: Wizard: Fix sections collapsing #399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
Issues pending maintainers triage
status/triage/manual
Manual triage in progress
status/triage/completed
Automatic triage completed
and removed
status/triage
Issues pending maintainers triage
labels
May 17, 2024
Haarolean
added
scope/frontend
Related to frontend changes
type/bug
Something isn't working
labels
May 19, 2024
Mgrdich
reviewed
May 21, 2024
Mgrdich
approved these changes
May 25, 2024
Thanks for approving @Haarolean ! This is an issue with the workflow I am thinking not code changes, right? |
@masonwoodford thanks for your first contribution to kafbat ui! It's related to the workflow running in a forked repo, ideally it shouldn't be running at all, there's an issue with the workflow I don't have time to take a look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/wizard
UI configuration wizard issues
scope/frontend
Related to frontend changes
status/triage/completed
Automatic triage completed
type/bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
I update the configure cluster sections to open and close properly. Prior to this change they would open, but not close consistently. I added a configOpen variable to manage this. Rather than passing undefined when the form is closed it now sets it to an {isActive: false}. Then the data is reset in transformFormDataToPayload based on that actual flag rather than null checking.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct