Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Wizard: Fix sections collapsing #399

Merged
merged 7 commits into from
May 27, 2024

Conversation

masonwoodford
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I update the configure cluster sections to open and close properly. Prior to this change they would open, but not close consistently. I added a configOpen variable to manage this. Rather than passing undefined when the form is closed it now sets it to an {isActive: false}. Then the data is reset in transformFormDataToPayload based on that actual flag rather than null checking.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

Screenshot 2024-05-17 at 12 07 05 PM

@masonwoodford masonwoodford requested a review from a team as a code owner May 17, 2024 19:07
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 17, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working labels May 19, 2024
@Haarolean Haarolean added this to the 1.1 milestone May 25, 2024
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label May 25, 2024
@Haarolean Haarolean changed the title Bug/fix configs FE: Wizard: Fix sections collapsing May 25, 2024
@Haarolean Haarolean added the area/wizard UI configuration wizard issues label May 25, 2024
@masonwoodford
Copy link
Contributor Author

Thanks for approving @Haarolean ! This is an issue with the workflow I am thinking not code changes, right?

@Haarolean Haarolean merged commit 1196f9f into kafbat:main May 27, 2024
11 of 12 checks passed
@Haarolean
Copy link
Member

@masonwoodford thanks for your first contribution to kafbat ui!

It's related to the workflow running in a forked repo, ideally it shouldn't be running at all, there's an issue with the workflow I don't have time to take a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wizard UI configuration wizard issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants