Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Update kappnav to v0.10.0 #744

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update kappnav to v0.10.0 #744

wants to merge 1 commit into from

Conversation

rlcundiff
Copy link
Member

No description provided.

@rlcundiff rlcundiff requested a review from mezarin May 29, 2020 18:58
@mezarin
Copy link
Collaborator

mezarin commented May 29, 2020

Hi @rlcundiff , thanks for the PR.
It appears that it is not quite ready. When deployed, the following error appears in the kappnav-operator pod:

{"level":"error","ts":1590788170.56161,"logger":"controller_kappnav","caller":"kappnav_controller.go:587 Reconcile","msg":"Failed to reconcile the KindActionMapping in Request.Namespace: kappnav, Request.Name: kappnav, Error: KindActionMapping.actions.kappnav.io \"default\" is invalid: spec.mappings.owner: Invalid value: \"object\": spec.mappings.owner in body must be of type string: \"object\"\ngithub.com/kappnav/operator/pkg/utils.ErrorWithStack\n\t/go/src/github.com/kappnav/operator/pkg/utils/utils.go:857\ngithub.com/kappnav/operator/pkg/utils.(*loggerImpl).getLogMessage\n\t/go/src/github.com/kappnav/operator/pkg/utils/logger.go:162\ngithub.com/kappnav/operator/pkg/utils.(*loggerImpl).logInJSON\n\t/go/src/github.com/kappnav/operator/pkg/utils/logger.go:141\ngithub.com/kappnav/operator/pkg/utils.(*loggerImpl).Log\n\t/go/src/github.com/kappnav/operator/pkg/utils/logger.go:122\ngithub.com/kappnav/operator/pkg/controller/kappnav.(*ReconcileKappnav).Reconcile\n\t/go/src/github.com/kappnav/operator/pkg/controller/kappnav/kappnav_controller.go:587\nsigs.k8s.io/controller-runtime/pkg/internal
...

The instance shows:

apiVersion: kappnav.operator.kappnav.io/v1
kind: Kappnav
...
spec:
  appNavAPI:
    repository: kappnav/apis
    tag: 0.10.0
  appNavController:
    repository: kappnav/controller
    tag: 0.10.0
  appNavUI:
    repository: kappnav/ui
    tag: 0.10.0
  extensionContainers:
    appNavInv:
      repository: kappnav/inv
      tag: 0.10.0
...
status:
  conditions:
    - lastUpdateTime: '2020-05-29T21:43:31Z'
      message: >-
        KindActionMapping.actions.kappnav.io "default" is invalid:
        spec.mappings.owner: Invalid value: "object": spec.mappings.owner in
        body must be of type string: "object"
      reason: Invalid
      status: 'False'
      type: Reconciled

@rlcundiff
Copy link
Member Author

Ah, since that CRD was updated it needs to be removed if you are reinstalling kappnav.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants