fix: added body in the http request so it takes parameters #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lili-wan <[email protected]>
lili-wan
changed the title
lili-wan
changed the title
Signed-off-by: lili-wan <[email protected]>
|
@AlexsJones Hi Alex, could you please help to trigger the workflow and merge the PR? thanks! We are waiting for this fix, really appreciated! |
@AlexsJones could you please check? thanks! |
AlexsJones
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
The http request does not take parameters from the request body because it is missing body definition in the proto file.
Adding the body in the definition, and tested locally
✅ Checks
ℹ Additional Information