Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of GH api request for E2E nightly #11148

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Oct 22, 2024

Proposed Changes

Nightly E2E suite is seeing failures due to limits on GH api calls for the "latest commit". This PR attempts to address this in several ways:

  • Allow E2E_RELEASE_VERSION=<commit_SHA> to install a specific commit SHA
  • For the nightly test suite. run the latest_commit.sh script before all the tests, then pass that commit into each test (reduces API calls from I nodes x J tests to a single API call)
  • Allow for an optional authenticated commits request via GH_TOKEN

Types of Changes

E2E, CI

Verification

Running on the nightly nodes by hand.

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner October 22, 2024 19:22
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.99%. Comparing base (8ce04d3) to head (af4b3dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11148      +/-   ##
==========================================
- Coverage   46.77%   41.99%   -4.78%     
==========================================
  Files         178      178              
  Lines       18498    18498              
==========================================
- Hits         8652     7769     -883     
- Misses       8496     9525    +1029     
+ Partials     1350     1204     -146     
Flag Coverage Δ
e2etests 34.20% <ø> (-8.01%) ⬇️
inttests 34.58% <ø> (+15.92%) ⬆️
unittests 13.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 9be4076 into k3s-io:master Oct 23, 2024
30 checks passed
@dereknola dereknola deleted the fix_e2e_commit branch October 23, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants