Fix Github Actions for Ubuntu-24.04 #11112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
reviewed
Oct 15, 2024
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11112 +/- ##
==========================================
- Coverage 49.91% 44.17% -5.75%
==========================================
Files 178 178
Lines 14820 14813 -7
==========================================
- Hits 7398 6544 -854
- Misses 6070 7062 +992
+ Partials 1352 1207 -145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
previously approved these changes
Oct 16, 2024
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Oct 16, 2024
vitorsavian
approved these changes
Oct 16, 2024
| "testing" | ||
| ) | ||
|
|
||
| // checkLock checks whether any process is using the lock | ||
| func checkLock(path string) bool { | ||
| lockByte, _ := exec.Command("lsof", "-w", "-F", "lfn", path).Output() |
There was a problem hiding this comment.
should we check for the error here? and return false if err != nil ?
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 4, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 4, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 4, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 5, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 5, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 5, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 5, 2024
* Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]>
This was referenced Nov 5, 2024
dereknola
added a commit
that referenced
this pull request
Nov 5, 2024
* Fix Github Actions for Ubuntu-24.04 (#11112) * Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]> * Pin vagrant to older version to avoid known issue 13527 Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Nov 5, 2024
* Fix Github Actions for Ubuntu-24.04 (#11112) * Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]> * Pin vagrant to older version to avoid known issue 13527 Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Nov 5, 2024
* Fix Github Actions for Ubuntu-24.04 (#11112) * Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]> * Pin vagrant to older version to avoid known issue 13527 Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Nov 5, 2024
* Fix Github Actions for Ubuntu-24.04 (#11112) * Fix vagrant/libvirt composite action for ubuntu-24.04 * Don't ignore changes to internal actions * Fix unit tests for ubuntu 24.04, new lsof version * Pin os version for unit and E2E workflows Signed-off-by: Derek Nola <[email protected]> * Pin vagrant to older version to avoid known issue 13527 Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix lsof output for flock utility function. Ubuntu 24.04 moved to a new(ish) version of
lsofwhich included Fix FD field description lsof-org/lsof#158.Fix composite action for libvirt/vagrant installation. Now works on ubuntu-24.04
Pinned e2e and unit test workflows to ubuntu-24.04 to prevent future disruption (in 2 years I can manually open PRs for ubuntu-26.04)
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments