Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make svclb as simple as possible" #11109

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

manuelbuil
Copy link
Contributor

This reverts commit 1befd65.

@manuelbuil manuelbuil requested a review from a team as a code owner October 15, 2024 14:30
cwayne18
cwayne18 previously approved these changes Oct 15, 2024
rbrtbnfgl
rbrtbnfgl previously approved these changes Oct 15, 2024
briandowns
briandowns previously approved these changes Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.

Project coverage is 44.23%. Comparing base (a44cb16) to head (a2edf36).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cloudprovider/servicelb.go 62.71% 19 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11109      +/-   ##
==========================================
+ Coverage   35.63%   44.23%   +8.59%     
==========================================
  Files         161      178      +17     
  Lines       14277    14820     +543     
==========================================
+ Hits         5088     6556    +1468     
+ Misses       8167     7056    -1111     
- Partials     1022     1208     +186     
Flag Coverage Δ
e2etests 36.49% <62.71%> (+0.85%) ⬆️
inttests 36.84% <62.71%> (?)
unittests 13.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 1befd65.

Signed-off-by: manuelbuil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants