Add PATH to k3s env in install script #11096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor Savian <[email protected]>
Signed-off-by: Vitor Savian <[email protected]>
brandond
reviewed
Oct 11, 2024
| @@ -963,6 +963,7 @@ create_env_file() { | |||
| $SUDO chmod 0600 ${FILE_K3S_ENV} | |||
| sh -c export | while read x v; do echo $v; done | grep -E '^(K3S|CONTAINERD)_' | $SUDO tee ${FILE_K3S_ENV} >/dev/null | |||
| sh -c export | while read x v; do echo $v; done | grep -Ei '^(NO|HTTP|HTTPS)_PROXY' | $SUDO tee -a ${FILE_K3S_ENV} >/dev/null | |||
| sh -c export | while read x v; do echo $v; done | grep -E 'PATH' | sed "s/'//g" | $SUDO tee -a ${FILE_K3S_ENV} >/dev/null | |||
There was a problem hiding this comment.
Why are we adding the user’s PATH to the systemd unit’s PATH?
Generally system services have a path that is intentionally more restricted than user paths. It is not really a best practice to add random untrusted paths to the service. If users have non-standard paths in their environment that they want K3s to use I think they should have to add these manually, I would not like to just grab whatever the user has in their env when they run the installer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When running with systemd, k3s cannot see the $PATH variable that the root has, so the runtimes searcher cannot find the additional runtimes dirs using the $PATH.
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments