Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containerd to v1.7.21, runc to v1.1.14 #10805

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Sep 3, 2024

Proposed Changes

Bump containerd to v1.7.21, runc to v1.1.14

Types of Changes

version bump

Verification

Check versions

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner September 3, 2024 23:23
@brandond brandond force-pushed the bump-containerd-runc branch 3 times, most recently from 04f24ea to b67ca9f Compare September 4, 2024 20:37
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.33%. Comparing base (de4bb2e) to head (8879559).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (de4bb2e) and HEAD (8879559). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (de4bb2e) HEAD (8879559)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10805      +/-   ##
==========================================
- Coverage   50.15%   43.33%   -6.83%     
==========================================
  Files         178      178              
  Lines       14753    14753              
==========================================
- Hits         7400     6393    -1007     
- Misses       6022     7178    +1156     
+ Partials     1331     1182     -149     
Flag Coverage Δ
e2etests 34.65% <ø> (-11.72%) ⬇️
inttests 36.81% <ø> (-0.01%) ⬇️
unittests 13.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwayne18
Copy link
Member

cwayne18 commented Sep 4, 2024

/trivy

This comment was marked as outdated.

@brandond
Copy link
Member Author

brandond commented Sep 4, 2024

Trivy appears to be full of crap.

root@k3s-server-1:/# k3s --version
warning: GOCOVERDIR not set, no coverage data emitted
k3s version v1.31.0+k3s-c509afd6 (c509afd6)
go version go1.22.5

root@k3s-server-1:/# /var/lib/rancher/k3s/data/current/bin/runc --version
runc version 1.1.14
commit: 12de61f
spec: 1.0.2-dev
go: go1.22.5
libseccomp: 2.5.5

root@k3s-server-1:/# go version -m /var/lib/rancher/k3s/data/current/bin/runc | grep x/net
	dep	golang.org/x/net	v0.24.0

From looking at the action log, it appears that the comment is triggering a scan of the master branch, not the PR branch.

@brandond brandond requested a review from a team September 4, 2024 22:25
@brandond brandond force-pushed the bump-containerd-runc branch from b67ca9f to 8879559 Compare September 4, 2024 22:58
@brandond
Copy link
Member Author

brandond commented Sep 4, 2024

/trivy

This comment was marked as outdated.

@brandond brandond merged commit d746073 into k3s-io:master Sep 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants