Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy latest commit on E2E tests #10725

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Our nightly E2E tests have not actually been deploying the latest commit. I found out when manually testing. This has been in place since 1454953 (3 months ago)

Types of Changes

Verification

using validatecluster test as an example
vagrant up server-0 will no other arguments now correctly deploys the latest commit build from AWS of K3s.

Testing

Its all testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner August 16, 2024 16:25
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.02%. Comparing base (649678b) to head (c3956bd).
Report is 14 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (649678b) and HEAD (c3956bd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (649678b) HEAD (c3956bd)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10725      +/-   ##
==========================================
- Coverage   49.58%   43.02%   -6.57%     
==========================================
  Files         179      179              
  Lines       14979    14979              
==========================================
- Hits         7428     6445     -983     
- Misses       6187     7342    +1155     
+ Partials     1364     1192     -172     
Flag Coverage Δ
e2etests 35.94% <ø> (-10.37%) ⬇️
inttests 19.67% <ø> (-17.01%) ⬇️
unittests 13.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit fc2eb49 into k3s-io:master Aug 26, 2024
29 checks passed
@dereknola dereknola deleted the Fix_E2E_commit branch September 3, 2024 16:58
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
dereknola added a commit that referenced this pull request Sep 4, 2024
dereknola added a commit that referenced this pull request Sep 4, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 6, 2024
dereknola added a commit that referenced this pull request Sep 6, 2024
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants