Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k3s-killall.sh support for custom data dir #10709

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

brandond
Copy link
Member

Proposed Changes

Fix k3s-killall.sh support for custom data dir that does not end with /k3s

Types of Changes

bugfix

Verification

See linked issue.

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner August 13, 2024 00:08
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.97%. Comparing base (019b0af) to head (b57df3c).

❗ There is a different number of reports uploaded between BASE (019b0af) and HEAD (b57df3c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (019b0af) HEAD (b57df3c)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10709      +/-   ##
==========================================
- Coverage   49.53%   42.97%   -6.57%     
==========================================
  Files         179      179              
  Lines       14979    14979              
==========================================
- Hits         7420     6437     -983     
- Misses       6207     7348    +1141     
+ Partials     1352     1194     -158     
Flag Coverage Δ
e2etests 35.90% <ø> (-10.34%) ⬇️
inttests 19.67% <ø> (-16.99%) ⬇️
unittests 13.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 649678b into k3s-io:master Aug 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants