-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow edge case OS rpm installs #10680
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10680 +/- ##
==========================================
- Coverage 49.46% 43.21% -6.25%
==========================================
Files 179 179
Lines 14955 14955
==========================================
- Hits 7397 6463 -934
- Misses 6192 7301 +1109
+ Partials 1366 1191 -175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The centos 7 test failure is a known issue (centos 7 is very EOL and the repos no longer exist), and I will open another PR to remove that test. |
Signed-off-by: Derek Nola <[email protected]> Co-Authored-By: ahmedali6 <[email protected]>
Signed-off-by: Derek Nola <[email protected]> Co-Authored-By: Blayne Campbell <[email protected]>
Signed-off-by: Derek Nola <[email protected]> Co-Authored-By: ErikJang <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
37c1fcf
Proposed Changes
Consolidates several disparate community PRs :
All original authors have been added as coauthors to each respective commit
note: we are not officially supporting or QAing these OSes.
Allows rpm installs:
Types of Changes
Install script feature
Verification
Manually tested with a modified version of the rocky-8 install test Tested on vagrant boxes using the following:
Testing
Not covered, no intention to. This is just to help various community requests.
Linked Issues
#8206
#10496
User-Facing Change
Further Comments