Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow edge case OS rpm installs #10680

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Allow edge case OS rpm installs #10680

merged 4 commits into from
Aug 7, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Consolidates several disparate community PRs :

All original authors have been added as coauthors to each respective commit

note: we are not officially supporting or QAing these OSes.
Allows rpm installs:

  • Fedora IOT (rpm + selinux)
  • Kylin V10 (rpm only)
  • Amazon Linux 2023 (rpm + selinux)
  • Amazon Linux 2 (rpm only)

Types of Changes

Install script feature

Verification

Manually tested with a modified version of the rocky-8 install test Tested on vagrant boxes using the following:

Testing

Not covered, no intention to. This is just to help various community requests.

Linked Issues

#8206
#10496

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner August 6, 2024 19:25
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.21%. Comparing base (3aceb85) to head (37c1fcf).

❗ There is a different number of reports uploaded between BASE (3aceb85) and HEAD (37c1fcf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3aceb85) HEAD (37c1fcf)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10680      +/-   ##
==========================================
- Coverage   49.46%   43.21%   -6.25%     
==========================================
  Files         179      179              
  Lines       14955    14955              
==========================================
- Hits         7397     6463     -934     
- Misses       6192     7301    +1109     
+ Partials     1366     1191     -175     
Flag Coverage Δ
e2etests 35.97% <ø> (-10.18%) ⬇️
inttests 36.69% <ø> (-0.03%) ⬇️
unittests 13.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola
Copy link
Member Author

The centos 7 test failure is a known issue (centos 7 is very EOL and the repos no longer exist), and I will open another PR to remove that test.

galal-hussein
galal-hussein previously approved these changes Aug 7, 2024
vitorsavian
vitorsavian previously approved these changes Aug 7, 2024
dereknola and others added 4 commits August 7, 2024 12:01
Signed-off-by: Derek Nola <[email protected]>
Co-Authored-By: ahmedali6 <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Co-Authored-By: Blayne Campbell <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Co-Authored-By: ErikJang <[email protected]>
@dereknola dereknola merged commit acb71ee into k3s-io:master Aug 7, 2024
35 of 36 checks passed
@dereknola dereknola deleted the new_oses branch August 12, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants