Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INSTALL_K3S_PR support #10472

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix INSTALL_K3S_PR support #10472

merged 1 commit into from
Jul 10, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 9, 2024

Proposed Changes

Fix INSTALL_K3S_PR support

The current test is wrong, as it fails if the grep for a 401 error DOES NOT match:

k3s/install.sh

Lines 490 to 491 in 4204248

if ! echo "$pr_raw" | grep -q "Bad credentials.*401" ; then
fatal "Installing PR builds requires GITHUB_TOKEN with k3s-io/k3s repo permissions"

Types of Changes

install script

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner July 9, 2024 20:56
@brandond brandond force-pushed the fix-pr-install branch 3 times, most recently from a3765b0 to c1d1217 Compare July 9, 2024 21:08
dereknola
dereknola previously approved these changes Jul 9, 2024
galal-hussein
galal-hussein previously approved these changes Jul 9, 2024
@brandond brandond dismissed stale reviews from galal-hussein and dereknola via f154334 July 9, 2024 22:00
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from galal-hussein July 9, 2024 23:42
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.44%. Comparing base (4204248) to head (b0e963c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4204248) and HEAD (b0e963c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4204248) HEAD (b0e963c)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10472      +/-   ##
==========================================
- Coverage   47.16%   41.44%   -5.73%     
==========================================
  Files         177      177              
  Lines       14830    14830              
==========================================
- Hits         6995     6146     -849     
- Misses       6532     7504     +972     
+ Partials     1303     1180     -123     
Flag Coverage Δ
e2etests 36.32% <ø> (-9.55%) ⬇️
inttests 19.92% <ø> (ø)
unittests 11.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond requested a review from a team July 10, 2024 07:33
@brandond
Copy link
Member Author

centos-7 test is broken due to centos7 EOL; merging

@brandond brandond merged commit d1709d6 into k3s-io:master Jul 10, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants