[Release-1.30] Set correct release channel for e2e upgrade test #10460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Jul 8, 2024
brandond
reviewed
Jul 8, 2024
| @@ -10,7 +10,7 @@ REGISTRY = (ENV['E2E_REGISTRY'] || "") | |||
| GOCOVER = (ENV['E2E_GOCOVER'] || "") | |||
| NODE_CPUS = (ENV['E2E_NODE_CPUS'] || 2).to_i | |||
| NODE_MEMORY = (ENV['E2E_NODE_MEMORY'] || 2048).to_i | |||
| GITHUB_BRANCH = (ENV['E2E_GITHUB_BRANCH'] || "master") | |||
| GITHUB_BRANCH = (ENV['E2E_GITHUB_BRANCH'] || "v1.30") | |||
There was a problem hiding this comment.
is there any way to template this from the CI environment, instead of having to explicitly set it on each branch?
There was a problem hiding this comment.
Yeah I don't love the manual setting. Probably get to that in the next few weeks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.30 #10460 +/- ##
===============================================
Coverage ? 41.48%
===============================================
Files ? 177
Lines ? 14830
Branches ? 0
===============================================
Hits ? 6152
Misses ? 7498
Partials ? 1180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola [email protected]
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
N/A
User-Facing Change
Further Comments