Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished k3s-ha implementation; Add three (3) cluster VIP methods implemented via ansible #166

Closed
wants to merge 109 commits into from

Conversation

jon-stumpf
Copy link
Contributor

@jon-stumpf jon-stumpf commented Dec 30, 2021

I have finished the k3s-ha implementation so that it implements the HA embedded database using etcd whenever three (3) or more servers are defined in hosts.ini. I have also implemented three methods to manage cluster VIPs in front of the control-plane:

  1. external
  2. kube-vip
  3. keepalived

This branch addresses:

I consider this branch stable although I have more to do (see TODO.md).

This work builds on my previous PRs: #158 and #164.

St0rmingBr4in and others added 30 commits February 19, 2021 00:36
This enables initializing a cluster in HA mode with an embedded DB.
https://rancher.com/docs/k3s/latest/en/installation/ha-embedded/

When multiple masters are specified in the master group, k3s-ansible will add
the necessary flags during the initialization phase.
(i.e. --cluster-init and --server)

For the embedded HA mode to work the k3s version must be >= v1.19.1

Signed-off-by: Julien DOCHE <[email protected]>
This replaces the `master_ip` var by `apiserver_endpoint` for genericity. The
init service is deployed only when k3s.service is not present on the machine to
ensure idempotence.

Signed-off-by: Julien DOCHE <[email protected]>
Signed-off-by: Julien DOCHE <[email protected]>
…ation only used in k3s/master role

Signed-off-by: Jon S. Stumpf <[email protected]>
…location is changed from the default

Signed-off-by: Jon S. Stumpf <[email protected]>
Signed-off-by: Jon S. Stumpf <[email protected]>
Signed-off-by: Jon S. Stumpf <[email protected]>
…se a commit versus a version number

Signed-off-by: Jon S. Stumpf <[email protected]>
…3; Added ctr to the list of symlinks

Signed-off-by: Jon S. Stumpf <[email protected]>
…ll_k3s_data_dir option in group_vars/all.yml

Signed-off-by: Jon S. Stumpf <[email protected]>
…, INSTALL_K3S_SKIP_ENABLE, INSTALL_K3S_SKIP_START

Signed-off-by: Jon S. Stumpf <[email protected]>

Squash me

Signed-off-by: Jon S. Stumpf <[email protected]>
…group_vars/all.yml (like all other install variables)

Signed-off-by: Jon S. Stumpf <[email protected]>
Signed-off-by: Jon S. Stumpf <[email protected]>
@jon-stumpf
Copy link
Contributor Author

@geerlingguy,

I would be interested in your critique of this work. Also, any suggestions for improvement.
Thanks.

- jss

@alexdresko
Copy link

/bump

@h0tw1r3
Copy link

h0tw1r3 commented Mar 18, 2022

working as intended. thank you for sharing your work!

@dereknola
Copy link
Member

Closing this. I appreciate you dedication to keeping this repo updated in your own fork @jon-stumpf. With the newest changes, this PR is heavily offset and will need a major overhaul. Also, going forward, this repo will not be implementing any VIP by default. With the api_endpoint variable, users can easily setup a VIP themselves and then connect into afterwards.

@dereknola dereknola closed this Nov 13, 2023
@jon-stumpf
Copy link
Contributor Author

Closing this. I appreciate you dedication to keeping this repo updated in your own fork @jon-stumpf. With the newest changes, this PR is heavily offset and will need a major overhaul. Also, going forward, this repo will not be implementing any VIP by default. With the api_endpoint variable, users can easily setup a VIP themselves and then connect into afterwards.

@dereknola You are the first committer to respond to my work from over two years ago. Are there capabilities that I implemented that are still not completed that an overhaul would be beneficial? And, if so, will someone respond to my pull request in a timely fashion?

@dereknola
Copy link
Member

I will take a look tomorrow at all the features built into your fork of this project. Any capabilities that would be beneficial I will open issues about. You can feel free to submit PRs for those features or not, your choice. Going forward, any PRs you submit I will attempt to answer within a few days. My main job is still K3s development but I should have time to maintain this repo (i.e. deal with new issues and PRs) just don't expect alot direct feature work from me after this week.

@jon-stumpf jon-stumpf deleted the k3s-ha branch November 21, 2023 01:09
@jon-stumpf
Copy link
Contributor Author

I am working on bringing my repo in-line with upstream. I am performing all my work on the rebase-upstream branch in my repo. As I get close, I will then look at producing PRs for your master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants