Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "binary" with "process" #366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manuelbuil
Copy link
Contributor

Basically sync with rancher/rke2-docs#297. There is just one thing

@manuelbuil manuelbuil changed the title Replace binary with process Replace "binary" with "process" Dec 19, 2024
docs/upgrades/manual.md Outdated Show resolved Hide resolved
3. Restart the k3s or k3s-agent service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Restart the k3s or k3s-agent service
3. Restart the k3s or k3s-agent service (systemd/openrc)
OR
Restart the k3s process (binary)

RKE2 does not operate as a standalone binary, but K3s very much can. So we need to to include both options. We just talked about the binary in the previous steps.

Copy link
Member

@brandond brandond Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They both function the same when run from a terminal. Rootless is actually the only thing that can't be run interactively.

I really hope that noone is running k3s from a shell. Honestly I would like to revise the rest of the docs to no longer suggest just running k3s server to start a node.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean.... isn't that what our k3s docker image does, run K3s in a shell, not a service?

Copy link
Member

@brandond brandond Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but also you can't upgrade the k3s docker image by replacing the binary and killing the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants