It's called vCPUs #352
Merged
It's called vCPUs #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melroy van den Berg <[email protected]>
|
Amazon directly refers in their documentation to the cores as
|
|
I think the nit was just the capitalization in the table headers. Which is kind of a very fine nit to pick but, ok, sure. |
Correct. Please reopen and merge. |
dereknola
approved these changes
Nov 4, 2024
|
@melroy89 Apologies, I completely misread your PR and thought that you were replacing vCPUS with VCPUS . The exact reverse of what your PR is actually doing. Clearly I was having a bad Friday. Approved and Merged, thank you finding this. |
|
Thanks. 🙏 No hard feelings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not
VCPUS, it should be:vCPUs