Add the warning for externalTrafficPolicy=Local #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manuelbuil <[email protected]>
VestigeJ
reviewed
Nov 1, 2024
| @@ -68,6 +68,10 @@ If the traffic to the external IP is subject to [Network Address Translation (NA | |||
|
|
|||
| Create a [Service of type LoadBalancer](https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer) in K3s. | |||
|
|
|||
| :::warning Known Issue | |||
| If external traffic reaches the node using a NAT (e.g. in public clouds) and you require `externalTrafficPolicy=local` for purposes such as client source IP preservation, please do not define the k3s config `node-external-ip` for any of the nodes, as that will not work correctly | |||
There was a problem hiding this comment.
nit: punctuation period at the end
without setting the node-external-ip people will have to set the tls-san correctly to be able to join extra nodes correct?
There was a problem hiding this comment.
Having node-external-ip set would be necessary for flannel to work properly, if all the nodes aren't on the same private network. So I guess this would be a tradeoff.
There was a problem hiding this comment.
exactly. People should use the internal-ip to join the cluster
VestigeJ
approved these changes
Nov 13, 2024
matttrach
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe how we could preserve the client source IP