Bump remark-lint-no-dead-urls from 1.1.0 to 2.0.0 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [remark-lint-no-dead-urls](https://github.com/remarkjs/remark-lint-no-dead-urls) from 1.1.0 to 2.0.0. - [Release notes](https://github.com/remarkjs/remark-lint-no-dead-urls/releases) - [Commits](remarkjs/remark-lint-no-dead-urls@v1.1.0...2.0.0) --- updated-dependencies: - dependency-name: remark-lint-no-dead-urls dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
brandond
approved these changes
Sep 30, 2024
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
|
@brandond This bump has introduced a bunch of irrelevant and frankly bad warnings about external url redirects, so I am changing this plugin to only produce a warning, not fail test builds. For example, it considers all URL redirects effictively "Bad" even when such redirects make sense: Additionally, valid anchors are now also tagged as dead: |
|
It looks like we can disable the anchor checking with an option - technically it's correct since the anchor isn't in the page, it's in an iframe on that page and they have some javascript that makes it work in the iframe. It is still dumb though. I don't see an option to make it not complain that you should link directly to the redirect target. |
|
Should we just pin to the old version? |
dependabot
bot
deleted the
dependabot/npm_and_yarn/remark-lint-no-dead-urls-2.0.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps remark-lint-no-dead-urls from 1.1.0 to 2.0.0.
Release notes
Sourced from remark-lint-no-dead-urls's releases.
Commits
c1365e12.0.0fcd9e43Change to require Node.js 18c95f89aUpdate dependency10ea90aFix type of disallowed optionb819084Refactor docs82a51cdRemove license yearc928f85Refactor Actions3e3b544Add.tsbuildinfoto.gitignore1c45081Update dev-dependenciesa9ced5dRefactor docsMaintainer changes
This version was pushed to npm by wooorm, a new releaser for remark-lint-no-dead-urls since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)