Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebars.js when accessing from related-projects #216

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Fix sidebars.js when accessing from related-projects #216

merged 6 commits into from
Dec 8, 2023

Conversation

LombardiDaniel
Copy link
Contributor

Just a fix sidebars.js when accessing from related-projects, the sidebar wasn't rendering when being accessed from that page.

Daniel Lombardi <[email protected]>

Signed-off-by: Daniel Lombardi <[email protected]>
Signed-off-by: Daniel Lombardi <[email protected]>
Signed-off-by: Daniel Lombardi <[email protected]>

Signed-off-by: Daniel Lombardi <[email protected]>
@brandond
Copy link
Member

brandond commented Dec 7, 2023

I almost called this out in review, but your screenshot showed that it was present in the sidebar so I figured it was working. Thanks for catching this!

Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase first, this PR is reapplying changes already merged into main

@dereknola dereknola merged commit de6f6f6 into k3s-io:main Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants