Fix installation network-options table #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luigi600 <[email protected]>
brandond
requested changes
Nov 28, 2023
docs/installation/network-options.md
Outdated
Comment on lines
22
to
30
| | CLI Flag and Value | Description | | ||
| |--------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `--flannel-ipv6-masq` | Apply masquerading rules to IPv6 traffic (default for IPv4). Only applies on dual-stack or IPv6-only clusters. Compatible with any Flannel backend other than `none`. | | ||
| | `--flannel-external-ip` | Use node external IP addresses as the destination for Flannel traffic, instead of internal IPs. Only applies when --node-external-ip is set on a node. | | ||
| | `--flannel-backend=vxlan` | Use VXLAN to encapsulate the packets. May require additional kernel modules on Raspberry Pi. | | ||
| | `--flannel-backend=host-gw` | Use IP routes to pod subnets via node IPs. Requires direct layer 2 connectivity between all nodes in the cluster. | | ||
| | `--flannel-backend=wireguard-native` | Use WireGuard to encapsulate and encrypt network traffic. May require additional kernel modules. | | ||
| | `--flannel-backend=ipsec` | Use strongSwan IPSec via the `swanctl` binary to encrypt network traffic. (Deprecated; will be removed in v1.27.0) | | ||
| | `--flannel-backend=none` | Disable Flannel entirely. | |
There was a problem hiding this comment.
Thanks for fixing the table formatting - but I don't think that it's necessary to pad these lines out with extra whitespace or hyphens to make the table line up in the raw view. Can you amend this to just fix the markdown?
There was a problem hiding this comment.
Usually, such a formatting is generated when using code formatters such as Prettier. Basically, however, I have oriented myself to the following tables, which are part of the main branch:
If a change is nevertheless desirable, I will make it.
Signed-off-by: Luigi600 <[email protected]>
brandond
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix that corrects the presentation of the Markdown table, as well as formatting the table.