Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Docusaurous 3.0.0 #200

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Update to Docusaurous 3.0.0 #200

merged 6 commits into from
Nov 20, 2023

Conversation

dereknola
Copy link
Member

Changes

  • Bump to new Docusaurous v3, largely this change concerns going from MDXv1 to MDXv3. As such, raw <> and {} needed to be converted (usually escaped or replaced with direct html code). See Upgrade Guide if you want more info.
  • Rework some tables to have a Default column for clarity
  • Fix broken links

VestigeJ
VestigeJ reviewed Nov 17, 2023
View reviewed changes
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just the two commented extra single quotes and then I can approve.

@dereknola
Remove extra `
41ab2cf 
Signed-off-by: Derek Nola <[email protected]>
VestigeJ
VestigeJ approved these changes Nov 17, 2023
View reviewed changes
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooice

@dereknola dereknola merged commit 428ec4c into k3s-io:main Nov 20, 2023
3 checks passed
@dereknola dereknola deleted the docusarous_v3 branch November 20, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VestigeJ VestigeJ VestigeJ approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @VestigeJ