Added IPv6 on the advertise-address description #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
requested changes
Sep 29, 2023
docs/cli/server.md
Outdated
| @@ -96,7 +96,7 @@ The following options must be set to the same value on all servers in the cluste | |||
| | --------------------------- | ------------------------ | -------------------------------------------------------------------------------------------- | | |||
| | `--bind-address` value | 0.0.0.0 | k3s bind address | | |||
| | `--https-listen-port` value | 6443 | HTTPS listen port | | |||
| | `--advertise-address` value | node-external-ip/node-ip | IPv4 address that apiserver uses to advertise to members of the cluster | | |||
| | `--advertise-address` value | node-external-ip/node-ip | IPv4/6 address that apiserver uses to advertise to members of the cluster (note that the primary service cluster IP range should be of the same family of the advertised address) | | |||
There was a problem hiding this comment.
We use IPv4/IPv6 for other flag descriptions, and a nit on the wording.
I think the note will also look better on a separate line
Suggested change
| | `--advertise-address` value | node-external-ip/node-ip | IPv4/6 address that apiserver uses to advertise to members of the cluster (note that the primary service cluster IP range should be of the same family of the advertised address) | | |
| | `--advertise-address` value | node-external-ip/node-ip | IPv4/IPv6 address that apiserver advertises for its service endpoint<br>Note that the primary `service-cidr` IP range must be of the same address family as the advertised address | |
rbrtbnfgl
force-pushed
the
advertise_ip
branch
from
9430453 to
233f6f7
Compare
Signed-off-by: Roberto Bonafiglia <[email protected]>
rbrtbnfgl
force-pushed
the
advertise_ip
branch
from
233f6f7 to
0de80d8
Compare
brandond
approved these changes
Oct 2, 2023
manuelbuil
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added IPv6 also on the
advertise-addressdescription because is a valid value in case IPv6 is the primary address for the service CIDR.