Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k3s2
in the k3s version string, so that we could choose eitherk3s2
ork3s1
cluster.x-k8s.io/deployment-name: worker-md-0
selector as in the upgrade test, it relies on this selector for selecting machines (adding the selector will avoid selecting the controlplane machines)Based on the local test result, it could upgrade a cluster from
v1.28.6+k3s2
tov1.28.7+k3s1
by modifyingKThreesControlPlane
andMachineDeployment
, so issue 84 might already be fixed.