-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
managedcluster-controller tests #830
Merged
zerospiel
merged 9 commits into
k0rdent:main
from
BROngineer:fix/issue-822-managedcluster-controller-test
Jan 6, 2025
Merged
managedcluster-controller tests #830
zerospiel
merged 9 commits into
k0rdent:main
from
BROngineer:fix/issue-822-managedcluster-controller-test
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BROngineer
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
5 times, most recently
from
December 27, 2024 23:38
20e9cdb
to
8010dd2
Compare
BROngineer
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
December 28, 2024 21:05
zerospiel
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, please consider to address
BROngineer
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
from
December 30, 2024 15:09
fe7bc24
to
58f8620
Compare
zerospiel
previously approved these changes
Jan 6, 2025
zerospiel
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
from
January 6, 2025 13:12
58f8620
to
b5f3a4c
Compare
@BROngineer pls update the PR regarding the project renaming (here is the error) |
BROngineer
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
2 times, most recently
from
January 6, 2025 13:47
817e3f1
to
5a339dc
Compare
zerospiel
approved these changes
Jan 6, 2025
Signed-off-by: Artem Bortnikov <[email protected]>
zerospiel
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
from
January 6, 2025 14:20
5a339dc
to
048512e
Compare
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
BROngineer
force-pushed
the
fix/issue-822-managedcluster-controller-test
branch
from
January 6, 2025 14:20
048512e
to
638f050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #822