Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managedcluster-controller tests #830

Conversation

BROngineer
Copy link
Contributor

Fixes: #822

@BROngineer BROngineer force-pushed the fix/issue-822-managedcluster-controller-test branch 5 times, most recently from 20e9cdb to 8010dd2 Compare December 27, 2024 23:38
@BROngineer BROngineer marked this pull request as ready for review December 28, 2024 21:05
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, please consider to address

internal/helm/actor.go Show resolved Hide resolved
internal/controller/template_controller_test.go Outdated Show resolved Hide resolved
internal/controller/template_controller_test.go Outdated Show resolved Hide resolved
internal/controller/clusterdeployment_controller_test.go Outdated Show resolved Hide resolved
@BROngineer BROngineer force-pushed the fix/issue-822-managedcluster-controller-test branch from fe7bc24 to 58f8620 Compare December 30, 2024 15:09
zerospiel
zerospiel previously approved these changes Jan 6, 2025
@zerospiel zerospiel force-pushed the fix/issue-822-managedcluster-controller-test branch from 58f8620 to b5f3a4c Compare January 6, 2025 13:12
@zerospiel
Copy link
Contributor

@BROngineer pls update the PR regarding the project renaming (here is the error)

@BROngineer BROngineer force-pushed the fix/issue-822-managedcluster-controller-test branch 2 times, most recently from 817e3f1 to 5a339dc Compare January 6, 2025 13:47
Signed-off-by: Artem Bortnikov <[email protected]>
@zerospiel zerospiel force-pushed the fix/issue-822-managedcluster-controller-test branch from 5a339dc to 048512e Compare January 6, 2025 14:20
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
@BROngineer BROngineer force-pushed the fix/issue-822-managedcluster-controller-test branch from 048512e to 638f050 Compare January 6, 2025 14:20
@zerospiel zerospiel merged commit 0adc43f into k0rdent:main Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ManagedCluster controller test enhancement
2 participants