Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jxcore version in install_and_run scripts #84

Merged
merged 3 commits into from
Oct 19, 2015

Conversation

cdynak
Copy link
Contributor

@cdynak cdynak commented Oct 19, 2015

it will be good to keep the most recent jxcore-cordova-relese version number in install_and_run scripts and all other places.
maybe it could be done automatically, using "version" attribute from package.json?

ktrzeciaknubisa pushed a commit that referenced this pull request Oct 19, 2015
update jxcore version in install_and_run scripts
@ktrzeciaknubisa ktrzeciaknubisa merged commit ee4bfdb into jxcore:master Oct 19, 2015
@ktrzeciaknubisa
Copy link
Member

Thank you. I've merged it although there is already 0.0.8 version :)

Generally your idea is right, but the use case for those two scripts was meant to just download one of them (instead of entire repo) and the script will do the rest. Relying on package.json etc. would force you to download package.json as well.

@cdynak
Copy link
Contributor Author

cdynak commented Oct 19, 2015

thank you for merging. :)
i've seen that there is 0.0.8 cordova release, but package.json, plugin.xml, io.jxcore.node.jxp and Changelog.md were updated according to 0.0.7: 0afb5c2
also version ?*8 (i don't get the version numbering) hasn't been announced at jxcore.com

i think, that downloading package.json is good idea, but of course not manually. rather the script itself should get it, parse version number, store in local variable and then use.

@ktrzeciaknubisa
Copy link
Member

Well, I was working on easier jxcore-cordova deployment for myself and there is already a working dev version of an installer, see #77.

@cdynak
Copy link
Contributor Author

cdynak commented Oct 19, 2015

i've already try it and it works very well. possibly it could replace platform specific scripts and become official tool under any less confusing name (like jxcordova). i'll attach my issues to your jxc repository. thanks very much!

@ktrzeciaknubisa
Copy link
Member

Thank you!

The jxc name was supposed to be short, but your proposal is good as well.

It's still under development, so you may encounter an error or two ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants