Update linting/formatting dependencies and remove old CI dependencies #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved from using yarn to NPM (package.json) Removed karma, mocha, and travis
Added prettier for formatting Moved from tslint -> eslint (tslint is depracated)
|
Also, note builds are successful though as @jcubic mentioned in #291 (comment) You may need to follow this Stack Overflow answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds are currently failing, so there is no harm in removing old CI dependencies (especially since they are very old). As for formatting and linting, tslint has been deprecated for some time now.
This PR removes the old CI dependencies and migrates from tslint to eslint and eslint-typescript. It also adds prettier for formatting. In addition, it removed yarn usage in favor of NPM's slightly better package-lock.
No code changes have been made in this PR (just config).