-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(umd): uglify the umd bundle #134
base: master
Are you sure you want to change the base?
Conversation
@izifortune — Awesome, thank you for your contribution! Is it possible to generate 2 versions of the UMD bundle?
That would be similar to how Angular Material generates bundles: Would you be able to do that? Thanks again! 👍 |
one *.umd.js and a *.umd.min.js as per comments
4917595
to
8d40638
Compare
@jvandemo i had to create another gulp task for this hope you don't mind. |
Curious why this hasn't been merged into current master? Thanks! |
@izifortune — I'm sorry, I missed your update. I will check it later this week and merge if all works as expected. Thanks again for your contribution! 👍 /cc @chrisalexander55. |
@jvandemo no worries happy to help :) |
when is that cool feature available? |
Resolved conflicts |
@izifortune — Looks like there is still a conflict. Would you be able to resolve it? If not, I can have a look at it as well. Thanks again! 👍 |
Umd bundle will be minified using the following rollup plugin:
https://github.com/TrySound/rollup-plugin-uglify