feat: added description and comment columns in all existing tables and apis #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauraww
force-pushed
the
feat/add-description-and-commit
branch
from
e80798d
to
8f36918
Compare
mahatoankitkumar
approved these changes
Nov 14, 2024
| @@ -0,0 +1,19 @@ | |||
| -- This file should undo anything in `up.sql` | |||
| -- contexts table | |||
There was a problem hiding this comment.
Are these needed?
There was a problem hiding this comment.
No , I will remove it
sauraww
force-pushed
the
feat/add-description-and-commit
branch
11 times, most recently
from
a37e9b2
to
dfc8172
Compare
mahatoankitkumar
requested changes
Nov 15, 2024
Datron
reviewed
Nov 18, 2024
| @@ -378,9 +378,21 @@ fn construct_new_payload( | |||
| }, | |||
| )?; | |||
|
|
|||
| let description = res | |||
| .get("description") | |||
| .and_then(|val| val.as_str()) | |||
There was a problem hiding this comment.
This returns result right? We should handle that
| let description = res | ||
| .get("description") | ||
| .and_then(|val| val.as_str()) | ||
| .map(|s| s.to_string()); |
There was a problem hiding this comment.
You can do this inside and_then
Comment on lines
9
to
10
| pub description: Option<String>, | ||
| pub comment: Option<String>, |
There was a problem hiding this comment.
This two should be mandatory in this case, the frontend should just send ""
sauraww
force-pushed
the
feat/add-description-and-commit
branch
14 times, most recently
from
c3b2999
to
0dd0666
Compare
sauraww
force-pushed
the
feat/add-description-and-commit
branch
from
0dd0666
to
0cd3db1
Compare
| .get("description") | ||
| .expect("Description not present") | ||
| .as_str() | ||
| .expect("Description is not a string") |
There was a problem hiding this comment.
instead of expect , can we return error
| @@ -81,11 +84,13 @@ async fn create( | |||
| function_name: fun_name.clone(), | |||
| last_modified_at: Utc::now().naive_utc(), | |||
| last_modified_by: user.get_email(), | |||
| comment: create_req.comment.into(), | |||
There was a problem hiding this comment.
into() is not needed here
| ALTER TABLE public.type_templates ADD COLUMN IF NOT EXISTS description TEXT DEFAULT '' NOT NULL; | ||
| ALTER TABLE public.type_templates ADD COLUMN IF NOT EXISTS comment TEXT DEFAULT '' NOT NULL; | ||
|
|
||
| ALTER TABLE public.functions RENAME COLUMN function_description TO description; |
There was a problem hiding this comment.
why function does not have comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Added description and comment columns in all existing tables and apis
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes