Support searching and sorting experiments via API and sorting on UI #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
force-pushed
the
search-experiments
branch
from
7455675
to
c666640
Compare
Datron
force-pushed
the
search-experiments
branch
from
c666640
to
523a478
Compare
|
|
||
| impl Default for SortBy { | ||
| fn default() -> Self { | ||
| Self::Desc |
There was a problem hiding this comment.
I feel default should be Asc
There was a problem hiding this comment.
@pratikmishra356 you always want to see the latest data, especially if you've been using Superposition for years.
There was a problem hiding this comment.
@Datron but it can differ based on entity , position/weight needs to be sort in asc order
| } | ||
| if let Some(ref context_search) = filters.context { | ||
| builder = builder.filter( | ||
| sql::<Bool>("context::text LIKE ") |
There was a problem hiding this comment.
are we type casting here ? context
There was a problem hiding this comment.
Yes we are, this just lets me modify the context type so I can use LIKE on it. It's currently an experiment to see if this is a viable way to search through contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is difficult to find experiments on different filters and sort them
Solution
PS: more frontend changes are to be expected to support searching. That is NOT present in this PR.
Screen.Recording.2024-11-08.at.2.35.02.PM.mov