feat(analytics): add first_attempt as a filter for PaymentFilters
#6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
tsdk02
changed the title
first_attempt as a filter for PaymentFilters
| @@ -104,6 +104,11 @@ where | |||
| .add_filter_in_range_clause(PaymentDimensions::ErrorReason, &self.error_reason) | |||
| .attach_printable("Error adding error reason filter")?; | |||
| } | |||
| if !self.first_attempt.is_empty() { | |||
| builder | |||
| .add_filter_in_range_clause("first_attempt", &self.first_attempt) | |||
There was a problem hiding this comment.
Why aren't we using a PaymentDimensions enum variant as the first param here?
There was a problem hiding this comment.
This is because, first_attempt is added only as a filter in PaymentFilters and not as a dimension in PaymentDimensions. Basically, this field can only be added as a filter and not as a group_by.
There was a problem hiding this comment.
We are also planning to segregate these structs based on the type of sources we have , but for now this is needed.
ShivanshMathurJuspay
approved these changes
Nov 20, 2024
SanchithHegde
approved these changes
Nov 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added
first_attemptas a filter inPaymentFilters.This is required for the new Analytics v2
Smart RetriesMetrics, specificallySmart Retries Successful DistributionandSmart Retries Failure Distribution, for calculations only involving smart retries (ignoring first attempts).Additional Changes
Motivation and Context
Helps in calculating certain metrics seamlessly.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy