-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(authn): Enable cookies in Integ #6599
Open
ThisIsMani
wants to merge
6
commits into
main
Choose a base branch
from
cookies-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
A-users
Area: Users
labels
Nov 18, 2024
Changed Files
|
ThisIsMani
changed the title
refactor(auth): Enable cookies in Integ
refactor(authn): Enable cookies in Integ
Nov 18, 2024
apoorvdixit88
previously approved these changes
Nov 21, 2024
SanchithHegde
previously approved these changes
Nov 21, 2024
ThisIsMani
dismissed stale reviews from SanchithHegde and apoorvdixit88
via
November 21, 2024 11:46
6febccb
SanchithHegde
previously approved these changes
Nov 21, 2024
racnan
reviewed
Nov 21, 2024
let final_token = if use_cookie_only { | ||
cookie_token_result? | ||
} else { | ||
cookie_token_result.unwrap_or(auth_header_token_result?.to_owned()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using cookie when config is false? Is this the desired behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, will change this to use auth header.
apoorvdixit88
approved these changes
Nov 22, 2024
racnan
approved these changes
Nov 22, 2024
SanchithHegde
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-users
Area: Users
C-refactor
Category: Refactor
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR will add logging for cookies and also make signout API accessible by any SPT.
Additional Changes
config/config.example.toml
config/deployments/integration_test.toml
config/deployments/production.toml
config/deployments/sandbox.toml
config/development.toml
config/docker_compose.toml
loadtest/config/development.toml
Motivation and Context
Closes #6598.
How did you test it?
If cookie is not present even if the auth header is present, BE will throw the following error
Checklist
cargo +nightly fmt --all
cargo clippy