Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: analytics revamp bug fixes #1703

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: analytics revamp bug fixes #1703

merged 3 commits into from
Nov 11, 2024

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Nov 9, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fixes new analytics ui bug fixes

  • Currency should be shown in correct denomination (divide by 100) when amount is being shown
  • Labels for success and failure distributions are not present for some of the group by - payment_method_type
  • Currency symbol like USD, INR or $, etc whenever amount is being showed
  • Percentage should be restricted to max 100% in rate related graphs
Screenshot 2024-11-09 at 11 48 08 AM Screenshot 2024-11-09 at 12 39 43 PM Screenshot 2024-11-09 at 12 39 58 PM Screenshot 2024-11-09 at 11 41 42 AM Screenshot 2024-11-09 at 11 41 48 AM

Motivation and Context

How did you test it?

bug fixed in this tickets are

  • Currency should be shown in correct denomination (divide by 100) when amount is being shown
  • Labels for success and failure distributions are not present for some of the group by - payment_method_type
  • Currency symbol like USD, INR or $, etc whenever amount is being showed
  • Percentage should be restricted to max 100% in rate related graphs

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug analytics labels Nov 9, 2024
@sagarnaikjuspay sagarnaikjuspay self-assigned this Nov 9, 2024
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner November 9, 2024 07:16
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@sagarnaikjuspay sagarnaikjuspay linked an issue Nov 9, 2024 that may be closed by this pull request
New analytics UI Bugs #1694
Open
26 tasks
@JeevaRamu0104 JeevaRamu0104 merged commit d78dee1 into main Nov 11, 2024
23 of 24 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the analytics-revamp-bug-fixes branch November 11, 2024 03:47
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed bug bug analytics labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@sagarnaikjuspay sagarnaikjuspay

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New analytics UI Bugs
2 participants
@sagarnaikjuspay @JeevaRamu0104