Dropdown Feature with props for List view #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can apply the theme styles from the Theme that is provided by the user configuration, which in turn derives the theme from the native configuration object. |
|
Sir, I have to remove it and |
3 tasks
manideepk90
added
the
hacktoberfest
|
Happy Diwali Everyone!! Will the PR be accepted today as it is the last day for hacktoberfest? |
manideepk90
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Suggested improvements:
- This PR is not working in mobile.
- The container styles can be replaced by viewStyle and text styles can be replaced by textStyle.
- the dlist logic can be improved.
- list is not rendering properly.
- rescript warning are listed.
- virtualization issues with flatlist
25harsh
force-pushed
the
main
branch
2 times, most recently
from
3988dd0
to
3230e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the the dropdown feature in which the full scrollable list is restricted to 2 elements of the list and dropdown for the other methods
also for backward compatibility so that user can choose between full list view and the new feature i have added prop to the custom tab view file for the same