Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL rewriting in loadPyodideOptions #105

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Mar 30, 2024

references

code changes

  • fix rewriting of *URL values in loadPyodideOptions
    • is currently trying to resolve the key instead of the value

  • add a static URL to demonstrate on RTD
    • right now, just adds ?from-lite-config=1, as we don't have a local lock handy

  • fix typing
    • lockFileURL, not pyodideLockURL

user-facing changes

  • site owners will be able to specify a loadOptions.pyodideLockURL (and maybe other URLs) and have them resolve correctly

notes

  • will also be checking this against a relative URL to an in-tree pyodide-lock.json, might need some more info in the URI constructor.
    • oof. relative URLs in the lockfile are calculated against indexURL.
    • for a locally-managed pyodide-lock.json to work, it will need to be deployed along with (at least) a pyodide.js
      • however, it won't have to ship the entire ~200mb distribution (if not wanted), as absolute URLs are respected

@bollwyvl bollwyvl changed the title Fix URL rewriting in loadPyodideOptions Fix URL rewriting in loadPyodideOptions Mar 30, 2024
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl bollwyvl added the enhancement New feature or request label Mar 30, 2024
@bollwyvl bollwyvl marked this pull request as ready for review March 30, 2024 12:42
@bollwyvl bollwyvl requested a review from jtpio March 30, 2024 12:42
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 8c2c62a into jupyterlite:main Mar 30, 2024
12 checks passed
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Mar 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants