Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Improve menus #289

Merged
merged 9 commits into from
Nov 18, 2021
Merged

Improve menus #289

merged 9 commits into from
Nov 18, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 17, 2021

Fixes #286

Incremental improvements for jupyter/notebook#6398.

First step to set up menu customization via the settings, so it's easier to have more control for each page

Before

image

After

image

image

image

image

TODO

  • Disable Edit, Run and Kernel for /tree
  • Disable Edit, Run and Kernel for /terminals
  • Disable Run and Kernel for /edit
  • Add "Trust Notebook" and "Rename" to the file menu
  • Add command to rename the document
  • Add UI Test to rename a file
  • Update snapshots:
    • Add new snapshots for menus
    • Existing snapshots

@jtpio jtpio added the enhancement New feature or request label Nov 17, 2021
@jtpio jtpio added this to the 0.3.x milestone Nov 17, 2021
@github-actions
Copy link
Contributor

Binder 👈 Launch RetroLab on Binder

@jtpio jtpio marked this pull request as ready for review November 18, 2021 16:38
@jtpio jtpio changed the title Disable some menus Improve menus Nov 18, 2021
@jtpio
Copy link
Member Author

jtpio commented Nov 18, 2021

Snapshots updated, and looking good when testing on Binder.

This should also help iterate on the menus, as mentioned in jupyter/notebook#6398.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve menus for the non-notebook pages
1 participant