Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handling non-existing fork room #420

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Gracefully handling non-existing fork room #420

merged 4 commits into from
Dec 18, 2024

Conversation

trungleduc
Copy link
Member

No description provided.

@trungleduc trungleduc added the enhancement New feature or request label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupyter-collaboration/delete-fork

davidbrochart
davidbrochart reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have something similar for the fork creation, when the root room ID doesn't exist.

davidbrochart
davidbrochart reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the error messages similar.

projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py Outdated Show resolved Hide resolved
projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py Outdated Show resolved Hide resolved
davidbrochart
davidbrochart approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trungleduc.

@davidbrochart
Copy link
Collaborator

CI failures are not related, see:

@davidbrochart davidbrochart merged commit dcce8f5 into jupyterlab:main Dec 18, 2024
11 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @davidbrochart