-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add js api #395
Merged
Merged
Add js api #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungleduc
force-pushed
the
fork-js-api
branch
9 times, most recently
from
November 8, 2024 09:48
b527451
to
ad954cc
Compare
trungleduc
force-pushed
the
fork-js-api
branch
from
November 8, 2024 09:57
ad954cc
to
719489e
Compare
davidbrochart
force-pushed
the
suggestions
branch
from
November 8, 2024 10:18
8ce9473
to
47811fd
Compare
* Add forking API * Add GET forks of root * Add fork Jupyter events * Replace query parameter merge=1 with merge=true * Add fork title and description
trungleduc
force-pushed
the
fork-js-api
branch
from
November 8, 2024 11:28
719489e
to
e0b4d4e
Compare
trungleduc
force-pushed
the
fork-js-api
branch
from
November 8, 2024 13:12
e0b4d4e
to
09f58a4
Compare
davidbrochart
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @trungleduc, this is great.
I just have a minor comment.
trungleduc
force-pushed
the
fork-js-api
branch
from
November 8, 2024 14:16
09f58a4
to
8329664
Compare
trungleduc
added a commit
that referenced
this pull request
Nov 29, 2024
* Add forking API (#394) * Add forking API * Add GET forks of root * Add fork Jupyter events * Replace query parameter merge=1 with merge=true * Add fork title and description * Add JS APIs --------- Co-authored-by: David Brochart <[email protected]>
trungleduc
added a commit
that referenced
this pull request
Nov 29, 2024
* Add forking API (#394) * Add forking API * Add GET forks of root * Add fork Jupyter events * Replace query parameter merge=1 with merge=true * Add fork title and description * Add JS APIs --------- Co-authored-by: David Brochart <[email protected]>
davidbrochart
added a commit
that referenced
this pull request
Nov 29, 2024
* Add forking API (#394) * Add forking API * Add GET forks of root * Add fork Jupyter events * Replace query parameter merge=1 with merge=true * Add fork title and description * Add js api (#395) * Add forking API (#394) * Add forking API * Add GET forks of root * Add fork Jupyter events * Replace query parameter merge=1 with merge=true * Add fork title and description * Add JS APIs --------- Co-authored-by: David Brochart <[email protected]> * Fix test_fork_handler * again * Allow time for update to propagate --------- Co-authored-by: David Brochart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes:
IForkManagerToken
in@jupyter/docprovider-extension
.