Log (instead of raise) exceptions when running as a server extension #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Zsailer
force-pushed
the
handle-exceptions
branch
from
bccf8be to
d6309ba
Compare
Zsailer
force-pushed
the
handle-exceptions
branch
from
d6309ba to
59a011a
Compare
jzhang20133
reviewed
Apr 29, 2024
jzhang20133
reviewed
Apr 29, 2024
jzhang20133
approved these changes
Apr 29, 2024
Zsailer
force-pushed
the
handle-exceptions
branch
2 times, most recently
from
d171191 to
fc8fd7d
Compare
jzhang20133
approved these changes
Apr 29, 2024
Zsailer
force-pushed
the
handle-exceptions
branch
from
fc8fd7d to
585e103
Compare
davidbrochart
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks @Zsailer, some comments but this should not block from merging.
projects/jupyter-server-ydoc/jupyter_server_ydoc/websocketserver.py
Outdated
Show resolved
Hide resolved
| f"Document Room Exception, (room_id={self._room_id or 'unknown'}): ", | ||
| exc_info=exception, | ||
| ) | ||
| return True |
There was a problem hiding this comment.
This is almost the same function as in websocketserver.py, except for the logging message. I think this should be factored out, with an extra-argument for the message.
There was a problem hiding this comment.
For sure. Since this is an internal definition right now, let's factor this out in a later PR. I want to proceed with merging, releasing, and testing.
…er.py Co-authored-by: David Brochart <[email protected]>
Zsailer
added a commit
to Zsailer/jupyter-collaboration
that referenced
this pull request
May 1, 2024
Zsailer
added a commit
to Zsailer/jupyter-collaboration
that referenced
this pull request
May 1, 2024
Zsailer
added a commit
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes some of #294, leveraging changes in pycrdt-websocket v0.13.1.
In #290, we see cases where the y-websocket server becomes unusable anytime an exception is raised within the y-websocket server's task groups. We made changes in pycrdt-websocket so that these exceptions could optionally be logged instead of raised, thereby keeping the server running.
This PR leverages those changes so we can ensure that there serve is never blocked.
We need to bump the pycrdt-websocket minimum version to get these changes.